fix(agent): use uv run for typecheck so env is synced before ty check#107
Open
scottschreckengaust wants to merge 2 commits into
Open
fix(agent): use uv run for typecheck so env is synced before ty check#107scottschreckengaust wants to merge 2 commits into
scottschreckengaust wants to merge 2 commits into
Conversation
`uvx ty check` ran ty in an ephemeral environment but auto-discovered the project's `.venv` for import resolution. When the venv was uninitialised (e.g. on first checkout before `mise run install` succeeded), site-packages was empty and ty could not resolve boto3, requests, pydantic, or claude-agent-sdk — causing //agent:quality to fail with `unresolved-import` errors. Switching to `uv run ty check` fixes this: uv syncs the project environment from uv.lock before running any command, so type-checking is always performed against the fully-installed dependency set regardless of whether the venv was pre-populated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Task-Id: 01KRPZ3PF8ZBRZ2600GRJS2VF7 Prompt-Version: 1c9c10e027a2
fix(agent): use uv run for typecheck so env is synced before ty check Merge pull request #2 from scottschreckengaust/bgagent/01KRPZ3PF8ZBRZ2600GRJS2VF7/fix-the-pre-existing-agentquality-type-c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Area
cdk— infrastructure, handlers, constructsagent— Python runtime / Docker imagecli—bgagentclientdocs— guides or design sources (docs/guides/,docs/design/)tooling— rootmise.toml, scripts, CI workflowsTip: AGENTS.md lists where to edit and which tests to extend.
Related
Changes
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.